[BWARE] Add HashMapIntToInt primitive int-to-int hash map#2478
Merged
Conversation
Introduce a specialized open-addressing map storing primitive int keys and values, avoiding boxing for integer-to-integer lookups used by compressed column-group operations.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2478 +/- ##
============================================
+ Coverage 71.37% 71.41% +0.03%
- Complexity 48749 48827 +78
============================================
Files 1571 1572 +1
Lines 188912 189059 +147
Branches 37067 37097 +30
============================================
+ Hits 134845 135024 +179
+ Misses 43601 43567 -34
- Partials 10466 10468 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cover put/get, putIfAbsent variants, collision chains, resize, iteration, and the primitive -1 absent-sentinel contract.
The entry iterator advanced bucketId twice per empty bucket (pre-increment in the loop condition plus the post-increment step), skipping entries when buckets were unevenly filled. Dense sequential keys masked it because the first probe always hit a non-null bucket. Add randomized tests that cross-check against java.util.HashMap to cover imbalanced bucket layouts, plus a chained-collision resize test, reaching full branch coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a specialized open-addressing map storing primitive int keys and values, avoiding boxing for integer-to-integer lookups used by compressed column-group operations.